Repository navigation
Unify Now Playing into one screen; fix mini player tap and list overlap - #143
Merged
Merged
Conversation
- NowPlayingView loses its home/sheet split: the home page now carries everything the expanded sheet had (large artwork, analysis meta line, live transition visualization, scrubber) plus a transition-settings chip under the transport. The sheet layout is deleted. - The mini player is a real Button (interactive glass, contentShape over the bar) that jumps the pager to Now Playing — the old onTapGesture on the glass surface never fired. - New shared .miniPlayerDock() attaches the bar per screen (library root AND pushed playlist detail): a safeAreaInset added outside the NavigationStack doesn't reach pushed destinations, which is why the bar covered the last row of playlist lists. - continuityGlass gains an interactive: option for tappable glass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
One Now Playing surface instead of two, and two mini-player bugs fixed.
Unified Now Playing
NowPlayingView's home/sheet split is gone. The home page (vertical pager center) now carries everything the mini-player-expanded sheet had:TransitionSettingsView— the config screen is now reachable from the default screenThe sheet layout and its chips are deleted; the mini player now jumps to the home page instead of presenting a second screen.
Bugs fixed
Mini player tap did nothing. It was an
onTapGestureon the Liquid Glass surface, which never fired. The bar is now a realButtonwithcontentShapeover the glass shape and.interactive()glass; play/next stay as inner buttons that win taps on their own frames.Mini player covered the last row in playlist lists. The bar's
safeAreaInsetwas attached outside theNavigationStack, and pushed destinations don't inherit insets added there — soPlaylistDetailView's list scrolled underneath the bar. A shared.miniPlayerDock()modifier now attaches the dock per screen (library root and playlist detail), so each list is inset by the dock's real height.Verification
MainPagerViewhere only swapsNowPlayingView(mode: .home)→NowPlayingView(); the backdrop-height fix stays in Size the pager backdrop to the full-bleed page height #142 (different hunk, merges cleanly in either order).🤖 Generated with Claude Code