Skip to content

Fix play-button crash: only sync-start stems once a render clock exists #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanylax0 merged 1 commit into from
Jul 18, 2026
Merged

Fix play-button crash: only sync-start stems once a render clock exists #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions Packages/ContinuityKit/Sources/Playback/Deck.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,20 @@ final class Deck {
// Two bare play() calls can land on different render quanta, starting the stems
// several ms apart — and nothing ever re-aligns them. Anchor both to one shared
// host-clock start just far enough out to cover the second call.
let start = AVAudioTime(hostTime: mach_absolute_time() + AVAudioTime.hostTime(forSeconds: 0.03))
accompPlayer.play(at: start)
vocalsPlayer.play(at: start)
//
// Only when the node already has a render clock: play(at:) on a node that hasn't
// seen an IO cycle yet (first start after engine build) throws the AVFAudio
// start-time exception and crashes on the play button. On that first start the
// two play() calls run back-to-back on a freshly started engine, which in practice
// lands them on the same quantum; every later start (pause/resume, seek) syncs.
if let render = accompPlayer.lastRenderTime, render.isHostTimeValid {
let start = AVAudioTime(hostTime: render.hostTime + AVAudioTime.hostTime(forSeconds: 0.03))
accompPlayer.play(at: start)
vocalsPlayer.play(at: start)
} else {
accompPlayer.play()
vocalsPlayer.play()
}
} else {
accompPlayer.play()
}
Expand Down
Loading