fix: add null guard to redo() to match undo() pattern#328
Merged
pradeeban merged 1 commit intoControlCore-Project:devfrom Feb 20, 2026
Merged
fix: add null guard to redo() to match undo() pattern#328pradeeban merged 1 commit intoControlCore-Project:devfrom
pradeeban merged 1 commit intoControlCore-Project:devfrom
Conversation
Author
|
hey @pradeeban this is one of the issue i mentioned in #311 while refactoring the server actions. fixing this redo() won't crash when no graph is loaded,, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #327
redo() was calling getGraphFun(state).redo() without checking if the graph exists first, while undo() right above it has the guard. will crash if you try to redo when no graph is loaded
just copied the same if check from undo() to keep them consistent.