Repository navigation
Add Boss Fight mode - #4
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
|
Browser QA passed: the Boss Fight Library entry opens with the boss art and a 3/3 lives badge. Lives went 3→2→1 as the first two attackers were sacrificed, and the third hit removed the boss for a White win. Undo restored a hit, the Black bot played to checkmate, Share → Link kept the art, and Classic is unchanged. A king may take the boss only on its last life (normal capture); sacrificial king hits are blocked by design. |
Contributor
There was a problem hiding this comment.
Devin Review found 4 findings. Devin automatically fixed all 4 findings.
Fixed by Devin (4)
- Compulsory hunts permit fatal king strikes — sacrificesRoyal now applied in both Predator compulsory branches.
- Existing archive statistics become unreachable — Default fields omitted; classic packs byte-identically to main (snapshot test).
- Unrecognized wins after sacrificial captures — detectOutcome now handles mover elimination and defender points after a hit.
- Forbidden royal hits cause false checkmate — Forbidden royal hits no longer count as forced captures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New built-in Boss Fight (Library): Black's whole army is fused into one winged, red-eyed boss facing White's classic 16 pieces — based on the "Elden Ring boss" chess clip.
PieceType.lives/PieceInstance.lives. Capturing a piece with >1 lives:victim.lives--, victim stays, attacker is destroyed. Last life → normal capture. Atomic/explosion blasts cost one life instead of killing. Kings can't strike a multi-life piece.variantCodec(which now also keeps app-relativeimages, so shared links keep the boss art).public/pieces/boss/boss.svg, rendered ~1.5x oversized with red eye glow, a lives badge, and a hit flash.Tests:
src/engine/boss.test.ts(hit progression, amazon moves, outcomes, effects, replay, codec, bot).tsgo -b,npm test(155 passed), oxlint, build all pass; played it in the browser vs the bot.Note: the boss is strong — careless openings (e.g. 1.e4 2.a3) can get mated by a knight-check from f3, since hitting the boss doesn't remove a checker.
Implemented in session Add the chess mode from the video
Review with Devin · Open in Devin Desktop