Repository navigation
feat(chart): inject the four remaining API keys from the Secret - #12
Merged
Merged
Conversation
CB_ANTHROPIC_API_KEY, CB_OPENAI_API_KEY and the Google Search pair were the only credentials the chart knew how to reference. The YouTube, SauceNAO, AudD and exchangerate keys had no path in at all, and config.extraEnv is the wrong one -- it renders into the ConfigMap, so a values file in Git would hold the plaintext. Same guard as the existing four: an unset key is not injected, and the feature then answers its "not found" string rather than erroring. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CB_ANTHROPIC_API_KEY,CB_OPENAI_API_KEYand the Google Search pair were the only credentials the chart knew how to reference. The YouTube, SauceNAO, AudD and exchangerate keys had no path in at all — andconfig.extraEnvis the wrong one, because it renders into the ConfigMap, so a values file in Git would hold the plaintext.Same guard as the existing four: an unset key is not injected, and the feature then answers its "not found" string rather than erroring.
helm templatewith the keys set putsCB_YOUTUBE_API_KEY,CB_SAUCENAO_API_KEYandCB_EXCHANGERATE_API_KEYin all three Deployments and the migrate Job.Needed by cookiebot-uat, which now holds the values in its
cookiebot-secretsSecret.🤖 Generated with Claude Code