fix: resume disconnected sessions in agent/compaction RPC handlers#491
Draft
fix: resume disconnected sessions in agent/compaction RPC handlers#491
Conversation
When the backend CLI drops a session, agent and compaction IPC handlers now catch the 'Session not found' error, call resumeDisconnectedSession, and retry — matching the existing pattern in copilot:send. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
maxtara
force-pushed
the
bug/agent-exception-1
branch
from
b2d3046 to
95880a0
Compare
maxtara
changed the title
getSessionAgents and getActiveAgent can be called by the renderer before the session finishes resuming in the main process. Return [] and null instead of throwing, since the renderer will re-query after sessionResumed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Agent and compaction IPC handlers (
copilot:setActiveAgent,copilot:getSessionAgents,copilot:getActiveAgent,copilot:compactSession) crash when the backend CLI has dropped the session but Cooper'ssessionsMap still holds a reference to it.Error:
This can happen any time the backend session expires, the CLI restarts, or a connection resets — not just at startup.
Fix
Added try/catch with
resumeDisconnectedSession+ retry to all four handlers, matching the existing pattern already used incopilot:sendandcopilot:sendAndWait. On aSession not founderror, the session is transparently reconnected and the operation retried.Also removed dead-code
if (!sessionState.session.rpc)guards — the SDK'srpcgetter is lazy-initialized and always returns a value.Validation
npm run build✅npm run dev✅