fix(grit-v2): REGION_CODES NameError in dataset-README generation#11
Merged
Conversation
stage_9 -> _write_readme -> _fallback_segment_lines iterated over an undefined `REGIONS` (introduced by dfa33e9); the constant is REGION_CODES. Crashed every full build after the data + manifest were written. Proof: the function now returns '- None' on empty input instead of raising NameError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 9 (
_write_readme→_fallback_segment_lines) iterated over an undefined `REGIONS` (typo forREGION_CODES, introduced by dfa33e9). This crashed the adapter at the very end of every full planetary build — after the data files and manifest were already written, so it does not corrupt output but does abort the run. Surfaced by the v0.3.0 GRIT rebuild.One-word fix:
REGIONS→REGION_CODES. Proof (real failing path, no mock):_fallback_segment_lines({})now returns- Noneinstead of raisingNameError. The published 0.3.0 dataset uses the hand-authoredhosting/grit-hfx-v0.3.0/README.md, not this generated one, so the dataset itself is unaffected.