Skip to content

Fix html issue on player store#3022

Open
chrisdugne wants to merge 2 commits intomasterfrom
fix-html-content
Open

Fix html issue on player store#3022
chrisdugne wants to merge 2 commits intomasterfrom
fix-html-content

Conversation

@chrisdugne
Copy link
Copy Markdown
Contributor

@chrisdugne chrisdugne commented Nov 27, 2025

  • Remplacé lodash.template() par un simple String.replace() avec regex
  • Évite le crash "SyntaxError: invalid statement" quand le contenu contient du HTML (
    , etc.)

Detailed purpose of the PR

Result and observation

  • Breaking changes ?
    If checked, what have you broken ?

  • Extra lib ?
    If checked, Which extra lib did you add ? (name, purpose, link ...).

Testing Strategy

  • Already covered by tests
  • Manual testing
  • Unit testing

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e84537a) to head (802d992).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #3022      +/-   ##
===========================================
+ Coverage   92.75%   100.00%   +7.24%     
===========================================
  Files         450        44     -406     
  Lines        7328      1062    -6266     
  Branches      600         0     -600     
===========================================
- Hits         6797      1062    -5735     
+ Misses        427         0     -427     
+ Partials      104         0     -104     
Files with missing lines Coverage Δ
...orpacademy-player-store/src/utils/state-extract.js 100.00% <100.00%> (ø)

... and 493 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d38331...802d992. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chrisdugne chrisdugne force-pushed the fix-html-content branch 8 times, most recently from 04fe750 to cbd02a2 Compare November 28, 2025 13:45
    - Évite le crash "SyntaxError: invalid statement" quand le contenu contient du HTML (<br/>, etc.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant