Skip to content

Do not introduce a npm engine when non existing ⛔ #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdrieanKhisbe merged 1 commit into from
Aug 5, 2025
+3 −1
Merged

Do not introduce a npm engine when non existing ⛔ #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/updatees/package.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
const getSemverPrefix = _.pipe(s => s && s.match(/^(\D*)\d+/), _.at(1));

const updatePackageEngines = async (node, npm, pkg, {exact = false, loose = true}) => {
// TODO: maybe support forcing the choice of prefix (example, to restore loose range like >=)

Check warning on line 28 in src/updatees/package.js

View workflow job for this annotation

GitHub Actions / build (22.x) 

Unexpected 'todo' comment: 'TODO: maybe support forcing the choice...'

Check warning on line 28 in src/updatees/package.js

View workflow job for this annotation

GitHub Actions / build (18.x) 

Unexpected 'todo' comment: 'TODO: maybe support forcing the choice...'

Check warning on line 28 in src/updatees/package.js

View workflow job for this annotation

GitHub Actions / build (20.x) 

Unexpected 'todo' comment: 'TODO: maybe support forcing the choice...'

Check warning on line 28 in src/updatees/package.js

View workflow job for this annotation

GitHub Actions / build (20.x) 

Unexpected 'todo' comment: 'TODO: maybe support forcing the choice...'

Check warning on line 28 in src/updatees/package.js

View workflow job for this annotation

GitHub Actions / build (18.x) 

Unexpected 'todo' comment: 'TODO: maybe support forcing the choice...'

Check warning on line 28 in src/updatees/package.js

View workflow job for this annotation

GitHub Actions / build (22.x) 

Unexpected 'todo' comment: 'TODO: maybe support forcing the choice...'
if (_.isArray(pkg)) return pMap(pkg, p => updatePackageEngines(node, npm, p, {exact, loose}));

if (!pkg) return;
Expand All @@ -37,7 +37,9 @@
node ? `${prefix ? prefix : getSemverPrefix(existingVersion)}${node}` : existingVersion
),
_.update('engines.npm', existingVersion =>
npm ? `${prefix ? prefix : getSemverPrefix(existingVersion)}${npm}` : existingVersion
existingVersion && npm
? `${prefix ? prefix : getSemverPrefix(existingVersion)}${npm}`
: existingVersion
)
)(await readPackage(pkg));

Expand Down
Loading