Skip to content

fix(chat): drop malformed user content instead of throwing #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidmckayv merged 2 commits into from
Sep 5, 2026
Merged

fix(chat): drop malformed user content instead of throwing #359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
029ac21
fix(chat): drop malformed user content instead of throwing
Ayush7614 Sep 4, 2026
3488c54
Merge remote-tracking branch 'origin/main' into gate359
davidmckayv Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/src/components/channels/chat-messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,12 @@ export function toVisibleChatItems(

if (message.role !== "user") return [];

if (
typeof message.content !== "string" &&
!Array.isArray(message.content)
) {
return [];
}
const text =
typeof message.content === "string"
? message.content
Expand Down
12 changes: 12 additions & 0 deletions app/tests/chat-messages.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,4 +154,16 @@ describe("toVisibleChatItems", () => {

expect(toVisibleChatItems([thinking])).toEqual([]);
});

test("drops a malformed live user turn instead of throwing", () => {
// Live turns bypass schema validation; one bad turn must not unmount the transcript.
for (const content of [undefined, null, 42] as unknown[]) {
const bad = {
id: "user-bad",
role: "user",
content,
} as unknown as Message;
expect(toVisibleChatItems([bad])).toEqual([]);
}
});
});