Refuse a bad COMPUTER_MEMORY_BYTES instead of capping a computer at 512 bytes - #374
Merged
davidmckayv merged 4 commits intoSep 5, 2026
Merged
Conversation
Empty COMPUTER_MEMORY_BYTES= is still unset (no cap). Suffix units such as 512m used to become 512 bytes via parseInt, which Docker accepts and Chromium cannot live in.
Bartok9
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso and
tylerslaton
as code owners
September 4, 2026 23:37
davidmckayv
approved these changes
Sep 5, 2026
davidmckayv
left a comment
davidmckayv
left a comment
Contributor
There was a problem hiding this comment.
Re-run after format fix (prior CI failure was a stale-run race on the pre-format sha). Current head passes format:check + full CI. Substance verified by composed build/tests + deep review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
COMPUTER_MEMORY_BYTES=512mused to become512viaparseInt, which Docker accepts as a memory cap Chromium cannot live in. EmptyCOMPUTER_MEMORY_BYTES=is still unset (no cap). Anything that is not a whole number of bytes now exits the supervisor before a computer is created — same empty-string / prefix trap as PORT (#343).Where it runs
Boundary and audit
Changelog
COMPUTER_MEMORY_BYTESrefuses to start.Proof
bunis not on this machine. Tests added insupervisor/tests/computer-memory-bytes.test.tsmatchinglisten-port.test.ts.