Skip to content

fix(server): accept uppercase duration units in durationMs #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidmckayv merged 2 commits into from
Sep 5, 2026
+2 −2
Merged

fix(server): accept uppercase duration units in durationMs #375

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a8e36a
fix(server): accept uppercase duration units in durationMs
Ayush7614 Sep 5, 2026
7d7673f
Merge remote-tracking branch 'origin/main' into gate375
davidmckayv Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions server/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,14 +735,14 @@ function privateHostsAllowed(environment: Environment): boolean {
* its meaning.
*/
export function durationMs(value: string): number {
const match = /^(\d+)\s*(ms|s|m|h)?$/.exec(value.trim());
const match = /^(\d+)\s*(ms|s|m|h)?$/i.exec(value.trim());
if (!match) {
throw new Error(
`"${value}" is not a duration. Write it as 30s, 30m, 2h, or a plain number of milliseconds.`,
);
}
const amount = Number(match[1]);
switch (match[2]) {
switch (match[2]?.toLowerCase()) {
case "h":
return amount * 3_600_000;
case "m":
Expand Down