fix(servers): reject whitespace-only id, title and url in POST /servers/custom - #376
Merged
davidmckayv merged 1 commit intoSep 5, 2026
Conversation
Ayush7614
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso and
tylerslaton
as code owners
September 5, 2026 10:09
davidmckayv
approved these changes
Sep 5, 2026
davidmckayv
left a comment
davidmckayv
left a comment
Contributor
There was a problem hiding this comment.
Trims id/title/url in POST /servers/custom, matching the sibling oauth-client route. Read against live code + deep review: optional-chaining guards, trimmed values stored, grant-nothing. Composed build/tests green. CI approved.
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /servers/custom checked truthiness only, so id/title/url of ' ' passed validation and reached the store. The sibling oauth-client route in the same file already trims, so this aligns the two.
Change: require trimmed non-empty id/title/url (400 otherwise) and pass trimmed values to addCustomServer.
Verified: tsc clean; bun test server/tests/plugin-catalogue.test.ts 43 pass.