feat(worker): validate env up front and normalise server URL - #380
Merged
davidmckayv merged 4 commits intoSep 5, 2026
Conversation
Ayush7614
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso and
tylerslaton
as code owners
September 5, 2026 10:17
davidmckayv
approved these changes
Sep 5, 2026
davidmckayv
left a comment
davidmckayv
left a comment
Contributor
There was a problem hiding this comment.
Re-run after format fix (prior CI failure was a stale-run race on the pre-format sha). Current head passes format:check + full CI. Substance verified by composed build/tests + deep review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The worker's three env guards used truthiness checks, so whitespace-only WORKER_SHARED_SECRET / SERVER_INTERNAL_URL / DATABASE_URL passed boot and then failed on every 30s tick (fetch to whitespace URLs, createDatabase on whitespace strings) as endless routine-sweep-tick-failed lines. A trailing-slash SERVER_INTERNAL_URL also built //internal/routines/run (404 reported only as 'answered 404 rather than 202'), and HOSTNAME='' produced the colliding owner 'routines/' the random fallback exists to avoid.
Change: new worker/src/env.ts with loadWorkerEnv() (trim + refuse whitespace like unset, strip trailing slashes, trim/fallback HOSTNAME) and routineRunUrl(); index.ts uses both. New worker/tests/env.test.ts (17 tests).
Verified: bun test worker/tests/ 18 pass; tsc clean for worker.