fix(app): guard channel socket against malformed payloads - #381
Merged
davidmckayv merged 2 commits intoSep 5, 2026
Merged
Conversation
Ayush7614
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso and
tylerslaton
as code owners
September 5, 2026 10:17
davidmckayv
approved these changes
Sep 5, 2026
davidmckayv
left a comment
davidmckayv
left a comment
Contributor
There was a problem hiding this comment.
Reviewed diff against current main; resolved CHANGELOG keep-both; validated locally (format + composed test run). CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The socket try/catch only covered JSON.parse, but JSON.parse('null') succeeds with null and JSON.parse('5') with 5. null reached isResync and threw TypeError on null.resync inside onmessage; numbers/strings/arrays passed through with channelId undefined, causing applyChannelEvent to return 'unknown' and a spurious roster-wide refetch. Binary frames (Blob) also relied on a cast.
Change: null-safe isResync(unknown), isChannelSocketMessage guard, and parseChannelSocketMessage() used by onmessage so unusable frames are dropped (no crash, no refetch). New app/tests/channel-socket-message.test.ts (32 tests).
Verified: new file 32 pass; existing channel-event-patch 14 pass; app tsc clean.