Skip to content

fix(worker): refuse a SERVER_INTERNAL_URL that is not a valid http(s) URL #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidmckayv merged 1 commit into from
Sep 6, 2026
+10 −0
Merged

fix(worker): refuse a SERVER_INTERNAL_URL that is not a valid http(s) URL #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions worker/src/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,16 @@ export function loadWorkerEnv(
"SERVER_INTERNAL_URL is not set, so this worker does not know where to hand a routine run.",
);
}
try {
const parsed = new URL(serverInternalUrl);
if (parsed.protocol !== "http:" && parsed.protocol !== "https:") {
throw new Error("not http(s)");
}
} catch {
throw new Error(
"SERVER_INTERNAL_URL must be a valid http(s) URL, so this worker knows where to hand a routine run.",
);
}

const databaseUrl = environment.DATABASE_URL?.trim();
if (!databaseUrl) {
Expand Down