Read an empty Bot PORT as unset, so NaN never reaches Bun.serve - #395
Merged
davidmckayv merged 3 commits intoSep 6, 2026
Merged
Conversation
agent-bot and agent-langgraph still used Number.parseInt(process.env.PORT ?? default). Empty PORT= is not undefined, so parseInt yielded NaN and Bun.serve bound an ephemeral port while compose published 4200/4201. Prefix typos started on the numeric prefix. Same trap as supervisor CopilotKit#343.
Bartok9
requested review from
MikeRyanDev,
davidmckayv,
guidovizoso and
tylerslaton
as code owners
September 5, 2026 23:37
davidmckayv
approved these changes
Sep 6, 2026
davidmckayv
left a comment
Contributor
There was a problem hiding this comment.
Deep-reviewed against live code (correctness, governance, no vendor/secret/scale issues). Composed build+tests green. CHANGELOG/format rebase on CI-validated substance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
PORT=onagent-bot/agent-langgraphused to parse asNaNandBun.servebound an ephemeral port while compose still published 4200/4201. Empty now means the shipped default; a non-digit value refuses to start. Same trap as supervisor #343.Where it runs
PORTat boot. No shared state.Boundary and audit
Changelog
CHANGELOG.mdunderUnreleased.Proof
Shared
listenPorttests: empty/whitespace → fallback; digits in range accepted;42o0/0/65536refused.