Repository navigation
Log MCP client close errors instead of silently swallowing them - #145
Closed
OpenGithubs wants to merge 1 commit into
Closed
OpenGithubs wants to merge 1 commit into
OpenGithubs wants to merge 1 commit into
Conversation
client.close() failures were completely suppressed with an empty catch. This masked MCP connection leaks and transport errors in server logs. Now we log the failure reason so operators can diagnose stuck connections.
Collaborator
|
Thanks for working on this. We're consolidating MCP close-error logging in #158, which covers the same cleanup paths, handles non-Error rejection values safely, and adds regression coverage. Closing this duplicate so implementation and review can continue there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug fix:
client.close()failures in the MCP and Parallel web-search transports were completely swallowed with.catch(() => {}). This masked transport leaks and connection errors in production — operators had zero visibility into why MCP connections accumulated or refused to close cleanly.Changes
src/server/connections.ts: log close() failure reasonsrc/server/parallel.ts: log close() failure reasonCommits
fix-close-logfix: log MCP client close errors instead of silently swallowing them