You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewed head 268772f8a395ad92f98ff33698f90713f1aca756. Found two non-blocking follow-ups, now tracked in #152. Proceeding with approval and merge with these accepted limitations; connected apps are opt-in and disabled by default:
[P2] Composio startup can outlive the turn timeout. In src/server/dot-agent.ts:339–347, session creation and tool discovery run before the inner agent exists and receive no abort signal. If either request stalls, the 90-second timeout aborts the controller but cannot finish the turn. A targeted test mocking pending session creation reproduced this: after advancing fake timers by 91 seconds, the stream remained open. Pass cancellation through the SDK requests and ensure abort completes the stream.
[P2] Connected apps cannot be enabled through the supplied Docker Compose setup.src/server/index.ts:44 reads COMPOSIO_API_KEY, but compose.yml never forwards it into the app container. Adding it to .env as documented therefore leaves the feature disabled and its controls hidden. Add COMPOSIO_API_KEY to the app service’s environment.
Validation: Typecheck and all 307 existing tests passed at the reviewed head. The added timeout regression probe failed. Review and probe were run in an isolated temporary copy; no source changes were made to the PR.
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 268772f. Typecheck and all 307 existing tests passed locally. Approving with the startup timeout/cancellation and Docker Compose configuration limitations accepted as non-blocking follow-ups tracked in #152.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crypto.randomUUIDis unavailable on a non-HTTPS development originTesting
npm run check-formatnpm run lintnpm run typechecknpm test(307 tests)npm run build