fix: never call the provider for a task cancelled during model setup - #101
Open
nvtoan0201-swe wants to merge 1 commit into
Open
nvtoan0201-swe wants to merge 1 commit into
nvtoan0201-swe wants to merge 1 commit into
Conversation
executeModelTask reads the agent identity and memories before registering its abort listener, and addEventListener never fires for an already-aborted signal. A task paused or cancelled inside that window still started a full model run. Check the signal after the setup reads so the run is rejected before any provider request. The new regression test cancels while the identity read is pending and asserts the fixture provider saw zero requests.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
executeModelTaskawaits the agent identity and memories before it registers its abort listener.AbortSignal.addEventListenernever fires for an already-aborted signal, so a task paused or cancelled during those reads still started a full model run — provider calls and credits spent for work the user had already stopped.The task signal is now checked right after the setup reads, before
agent.run()is reached, so the cancellation path re-queues/pauses without contacting the provider.The new regression test in
tests/model-worker.test.tsdelays the identity read, pauses the task while it is preparing, and asserts the fixture provider received zero requests. I verified the test fails on the previous code (1 !== 0) and passes with the fix.Verification
pnpm test— 277 pass, 0 fail (1 new)pnpm lintpnpm typecheckIntegration limits
Fixtures only; no live provider was called. This closes the setup window; aborts after
agent.run()starts were already handled by the existing listener.AI assistance was used to prepare this change; I reviewed the code, tests and checks above.