Repository navigation
fix: normalize a typed browser address before opening a session - #102
Merged
jerelvelarde merged 2 commits intoOct 6, 2026
Merged
Conversation
BrowserScreen posted the raw text from Open session, while the in-session address bar and the computer sheet both run browserAddress first. The server requires an absolute URL, so typing copilotkit.ai failed validation even though the same text works everywhere else. Normalize the address before the request; browserAddress already covers schemes, credentials, and malformed input in its own tests.
jerelvelarde
approved these changes
Oct 6, 2026
jerelvelarde
left a comment
Collaborator
There was a problem hiding this comment.
Value: typed browser addresses use the existing normalization/validation helper before opening a session. Two address-helper tests, changed-file Biome, mobile typecheck and diff checks pass after retaining both browserAddress and startOfZonedDay imports during main integration. Worker-side URL/security policy remains intact. Template: clear narrow fix and checks; please add UI evidence/platform limits if not supplied. No actionable security issue. Merge after required CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The Browser screen's "Open session" button posted the raw text field value, while the in-session address bar (
details.tsx) and the computer sheet (computer.tsx) both normalize throughbrowserAddressfirst. The server requires an absolute URL (z.url()), so typingcopilotkit.aiin this one field failed validation even though the same text works in every other browser entry point.The address is now normalized before the request.
browserAddressalready covers scheme-less hosts, credentials, and malformed input inapps/mobile/test/browser-address.test.ts.Verification
pnpm test— 276 pass, 0 failpnpm lintpnpm typecheck(root + mobile)Integration limits
The component wiring itself is not covered by the repo's
node:testhelpers (they cover pure modules); the normalization helper it calls is covered.AI assistance was used to prepare this change; I reviewed the code and ran the checks above.