Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
maintain()currently callspublishOutcome()for every durable task on every 60s pass.publishOutcome()immediately re-reads the task, so steady-state work grows with lifetime task count rather than active/recoverable work.A downstream PGlite benchmark of the equivalent skip logic measured:
Change
Record the exact notification outcome key in
state.publishedOutcomeafter publication, and skip rows whose current outcome key already matches that marker.The marker write uses a new nested JSON compare-and-set primitive instead of replacing the whole
stateobject. That matters because publication can race another same-status state update; sibling state must survive.Crash semantics stay conservative:
waiting_inputquestion) fail the old marker CAS and are republished on the next pass.Tests
New outcome-level regressions cover:
No connector, UI, or task-execution behavior changes.