Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every
createTaskcall currently loads the entire durable task table and filters terminal rows in JavaScript to enforce the 100-active-task cap. Terminal tasks are retained, so this check gets more expensive over the lifetime of a workspace.A downstream PGlite benchmark with 2,000 ~2KB task rows measured roughly:
list()+filter: ~282.7ms / ~3.0MB transferredChange
Add
Store.countActiveTasks()and push the terminal-status exclusion into SQL.COALESCEpreserves the previous behavior where a status-less task counts as active.createTaskstill applies the same >=100 cap and the same terminal set.Regression
The persistence test compares the SQL result to the previous
list()+filtersemantics across all task statuses, including a status-less record, and verifies owner/kind isolation.No cap value, task lifecycle, or API behavior changes.