Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Pausing a goal currently loads every durable task for the owner, then filters by
goalIdin JavaScript. Terminal task history is retained, so this path gets slower as the workspace ages.A downstream PGlite benchmark with 2,000 ~2KB task rows measured roughly:
goalIdfilter: ~6.9ms / ~78KBChange
Add
Store.listByGoalId()with the sameupdated_at DESC,idordering aslist(), and use it only for the paused-goal cascade.The remaining predicates are unchanged:
goalIdnever match.Regression
Persistence coverage compares the scoped query directly with the previous
list().filter(item.goalId === id)semantics and checks owner/kind isolation.No goal lifecycle or task-control behavior changes.