Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BrowserService.imports()is the only mutating per-session browser operation that does not use the existingserial(id)queue.The download dedupe path is check-then-act:
browser-downloads/<downloadId>;Two concurrent import requests can both pass step 1 and import the same download twice, leaving duplicate file rows/orphaned bytes.
Change
Route
imports()through the existing per-session serial queue and move the current implementation intoimportsOwned().The second caller then observes the first caller's dedupe row and returns the same signed file.
Regression
A focused test races two imports for one PDF download against a stub worker and asserts:
No download format, signing, or browser navigation behavior changes.