Skip to content

Delegate existing goal milestones while keeping completion manual - #123

Merged
jerelvelarde merged 3 commits into
CopilotKit:mainfrom
wangtaotaotao95:feat/delegate-goal-milestones
Oct 6, 2026
Merged

jerelvelarde merged 3 commits into
CopilotKit:mainfrom
wangtaotaotao95:feat/delegate-goal-milestones

Conversation

@wangtaotaotao95

@wangtaotaotao95 wangtaotaotao95 commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Closes #72.

Goal milestones can now open the existing delegation sheet with their goal and milestone context. The task keeps a stable milestoneId, appears under that milestone with its real status, and opens the existing task/artifact detail. A successful task leaves the milestone unchecked for the user to complete explicitly; it does not append a duplicate completed milestone. Goal-only tasks retain their existing behavior.

Creation validates goal ownership and milestone membership. The sheet reuses a request ID after a failed submission, while a later explicit delegation gets a new task. Deleted milestones stay deleted and task detail explains the missing link. Checkbox updates now change only the selected milestone in one database statement, preserving current titles, ordering, other completion states and concurrent additions. Goal status updates likewise no longer write a stale full goal snapshot.

Validation on Node 24.21.0 / pnpm 11.19.0:

  • All 281 tests pass, including ownership/membership rejection, concurrent request replay, separate later delegation, rename/reorder/deletion, concurrent manual progress, successful/failed/cancelled/review-blocked outcomes, legacy goal tasks, and persisted results after database restart.
  • pnpm lint, pnpm typecheck, pnpm --dir apps/worker typecheck, pnpm build:server, pnpm build:web, pnpm build:ios, pnpm build:android pass.
  • Chromium sample-workspace walkthrough: delegate an existing milestone to the finance workflow, open its successful result, verify it remains unchecked with no duplicate milestone, and manually complete only that milestone. Checked desktop and phone-sized Web layouts. Rich Threads provisioning was stubbed; finance execution and milestone APIs used the real local server/database.
  • Native simulator/device runtime and live provider paths were not tested. iOS/Android checks above are bundle exports, not native runtime validation.

Screenshots (fictional sample data; review assets are kept outside the source branch):

Desktop milestone with linked successful task

Phone-width Web preview: successful task does not check the milestone

AI assistance: implemented and verified with Codex.

Current-main verification — 2026-10-06

Integrated main 73a7149, retaining this PR’s behavior and all upstream regression coverage. Full suite: 393 tests passed. Lint, root/mobile/worker typechecks and server build pass on Node 26.8.2. Updated-head CI covers the browser/container and platform lanes. No live providers or native-device session were used.

@jerelvelarde jerelvelarde left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Value: delegate existing milestones without auto-completing them. Owner/milestone validation, retry identity, concurrent checkbox preservation, paused-goal behavior and orphaned-task visibility are covered. Twenty-seven agent/workflow tests, Biome all changed files and diff checks pass after resolving import-only main conflict. Template supplies screenshots and limits. No actionable security/correctness finding. Merge after required CI.

@jerelvelarde
jerelvelarde merged commit 2228f0f into CopilotKit:main Oct 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Delegate existing goal milestones and link their task results

2 participants