Repository navigation
feature: let background tasks operate web pages - #67
Closed
asasemahmed wants to merge 2 commits into
Closed
asasemahmed wants to merge 2 commits into
asasemahmed wants to merge 2 commits into
Conversation
Contributor
|
Closing. This includes all of #62 and runs it unattended, so it inherits every problem listed there, and it adds more. It deletes the task-prompt instruction "interactive reservations currently require user browser takeover" without replacing it. When a risky step is refused, the task asks a free-text question and never checks the answer: replying "NO. Do not place the order. Stop." still lets the confirmed click through. A confirmed click that times out or crashes stays armed and can be replayed, which breaks the CONTRIBUTING rule "do not retry a possibly completed write." Page writes by background tasks need the same persisted action review sends use, and agreed scope in an issue, before a change like this is proposed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #62, so this PR includes its commit until #62 is merged.
What changed
Background tasks can now operate the page
read_webopened:page_elements,page_actandsave_page_downloads.Verification
pnpm typecheckpasses.