Repository navigation
fix: use the saved name, tone and memories in chat - #68
Shubhdeep12 wants to merge 1 commit into
Conversation
Updated the ConversationAgent to dynamically read the agent's name, tone, and memories on each run, allowing for personalized responses. The agent's prompt now incorporates these details, ensuring that memories are treated as data rather than instructions. Additionally, documentation has been updated to reflect these changes in the agent's functionality.
|
Needs a change before merge. |
jerelvelarde
left a comment
There was a problem hiding this comment.
Value: useful saved identity, tone and memories in chat. Four focused personal-context tests passed; owner-scoped reads, untrusted-data framing and forgotten-memory behavior are appropriate. Template includes example UI evidence, checks and provider limits. No additional actionable security issue found. Current production conflict in apps/server/src/engine/conversation.ts blocks integration; please retain both this context behavior and main's newer calendar/tools/Jev lifecycle, then rerun checks on the integrated head.
What changed
Name, tone and memories can be set in Apps, and background tasks already use them (
model.ts), but the main chat didn't.Its prompt was hardcoded to "You are OpenMuse", and memories only reached it if the model happened to call
agent_status. So memories saved byremember_factin chat were never read back by chat.Chat now loads the identity and memories before each reply, the same way tasks do:
{ text, source }, marked as data, not instructions (same framing as tasks).Verification
tests/conversation-personal-context.test.ts.pnpm lint,pnpm typecheck,pnpm test(175 passing) andpnpm build:serverpass.Integration limits
Added a preference - "I prefer vegetarian" and tried it before and after the fix.
