Skip to content

fix: make the computer button label match its status - #77

Merged
jerelvelarde merged 2 commits into
CopilotKit:mainfrom
asasemahmed:fix/computer-status-label
Oct 6, 2026
Merged

jerelvelarde merged 2 commits into
CopilotKit:mainfrom
asasemahmed:fix/computer-status-label

Conversation

@asasemahmed

Copy link
Copy Markdown
Contributor

What changed

The header's computer button always had the accessibility label "Agent computer — take control", even when it showed "offline" or "ready", so screen readers announced the wrong state. The visible status and the label now come from one computerStatus() helper.

Verification

  • New apps/mobile/test/computer-status.test.ts covers offline, ready and take control.
  • Web app, sample workspace: with the worker stopped the button's accessible name is "Agent computer — offline"; with it running, "Agent computer — ready". No visual change.
  • pnpm typecheck, biome ci on the changed files, pnpm test (206 passed, 0 failed, 1 skipped) and pnpm build:web pass. Not checked with VoiceOver/TalkBack on a device.

@jerelvelarde jerelvelarde left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Value: accessible computer status now matches the existing visible state, preserving offline priority. One focused status test passed. Template includes web verification and explicitly untested VoiceOver/TalkBack. No actionable security issue. Updated-main diff reviewed; merge after required CI.

@jerelvelarde
jerelvelarde merged commit 1ed51c8 into CopilotKit:main Oct 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants