Accept a scheme-less browser worker address - #92
Merged
Merged
Conversation
Render's private hostport has no protocol, and fetch rejects that value. Existing http and https worker URLs are left unchanged.
tylerslaton
approved these changes
Sep 29, 2026
sunshaoan0808
pushed a commit
to sunshaoan0808/openmuse
that referenced
this pull request
Sep 30, 2026
Accept a scheme-less browser worker address. Render's private hostport has no protocol, and fetch rejects that value. Existing http and https worker URLs are left unchanged. Co-authored-by: Ojus Save <ojusave@users.noreply.github.com>
sunshaoan0808
pushed a commit
to sunshaoan0808/openmuse
that referenced
this pull request
Sep 30, 2026
上游 5 个提交：JEV(CopilotKit#42)、无 scheme worker 地址(CopilotKit#92)、web 输入框焦点(CopilotKit#89)、 worker 测试健壮性(CopilotKit#90)、render 蓝图(CopilotKit#86)。 冲突解决（4 文件 9 块）与本地适配： - conversation.ts：以上游 JEV 结构（runInternal/choices 分支/noteEvidence）为基座， 换回我们的中性工具层（forAgUi + chatTools），并把 noteEvidence 改成经 ChatToolContext 回调； prompt 用我们的 chatInstructions() + JEV 段 + computerInstructions；恢复 maxSteps=10 与 sample 分支的 threadId 注入 - agent.ts：保留我们的 mastra 引擎分支，两处 ConversationAgent 注入 sharedJevAdapter() - chat.tsx：我们的卡片（搜索/浏览器操作/审批）与 JEV 卡片并存，去重 delegate_task 渲染器 - config.ts：去掉 cherry-pick 造成的 browserWorkerUrl 重复定义 - mastra-engine.ts：JEV 工具与指令补到 mastra 路径（上游只挂自带引擎，我们线上跑 mastra） - jev/tools.ts：抽出 presentChoicesSpec 中性规格，两条引擎共用同一份校验逻辑 验证：pnpm test 321/321 通过（含上游 JEV 全部测试）
Wiltermoodj
pushed a commit
to Wiltermoodj/openmuse
that referenced
this pull request
Oct 4, 2026
Accept a scheme-less browser worker address. Render's private hostport has no protocol, and fetch rejects that value. Existing http and https worker URLs are left unchanged. Co-authored-by: Ojus Save <ojusave@users.noreply.github.com> (cherry picked from commit 88d2964)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
BROWSER_WORKER_URLcan now be either a full URL orhost:port. A value without a scheme getshttp://added before the API calls the worker.http://andhttps://values are left as they are, so local setup, Docker Compose, the demo, and tests keep the same address.Verification
pnpm exec tsx --test tests/config.test.tspassed, including:http://127.0.0.1:8790stays unchangedhttps://browser.internal:8790stays unchangedopenmuse-browser-h4fx:8790becomeshttp://openmuse-browser-h4fx:8790