fix: compare all-day events in their calendar's time zone - #96
Open
nvtoan0201-swe wants to merge 1 commit into
Open
nvtoan0201-swe wants to merge 1 commit into
nvtoan0201-swe wants to merge 1 commit into
Conversation
EventEditor parsed date-only starts and ends as UTC midnight, so an all-day event could miss a timed event later that local day or flag an event on the previous day. The conflict row also printed clock times for all-day events, and the Next 30 days header showed all-day events one day early west of UTC. Add calendarInterval/calendarOverlap helpers that resolve date-only values through zonedInstant, use them for conflict detection, and label all-day conflicts and headers from their date.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
All-day events are date-only values, but the mobile event editor compared them with raw
Date.parse, which treats"2026-09-30"as UTC midnight:apps/mobile/src/details.tsx).apps/mobile/src/screens.tsx).This adds
calendarInterval/calendarOverlapto the existing pure time helpers (apps/mobile/src/date-time.ts), which resolve date-only values throughzonedInstantin the event's own zone. Both are covered inapps/mobile/test/date-time.test.ts(LA evening overlap, previous-day non-overlap, Tokyo date boundary, boundary touch, invalid zones/dates).Verification
pnpm test— 281 pass, 0 fail (5 new tests)pnpm lintpnpm typecheck(root + mobile)No simulator/device run; only pure interval logic and labels changed.
Integration limits
Existing stored events already carry
allDayandtimeZone, so no data migration is needed.AI assistance was used to prepare this change; I reviewed the code, tests and checks above.