fix: list calendars without an explicit time zone - #98
Open
nvtoan0201-swe wants to merge 1 commit into
Open
nvtoan0201-swe wants to merge 1 commit into
nvtoan0201-swe wants to merge 1 commit into
Conversation
nvtoan0201-swe
force-pushed
the
fix/calendar-list-timezone
branch
from
September 30, 2026 04:47
9520654 to
47bbaf6
Compare
Google marks CalendarListEntry.timeZone as optional. Requiring it made one zone-less calendar fail the whole listCalendars read, which also failed the workspace snapshot. Default the entry to UTC and keep the rest of the list readable. Add a fixture test for an entry with no timeZone.
nvtoan0201-swe
force-pushed
the
fix/calendar-list-timezone
branch
from
September 30, 2026 04:50
47bbaf6 to
76af24a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Google documents
CalendarListEntry.timeZoneas optional, but the integration required it in two places:listCalendars: one calendar without a zone made the wholecalendarListread throw, which then failed/api/calendarsand the workspace snapshot for the entire app.reviewEvent: when neither the event nor its calendar carried a zone, update/delete reviews failed before they could be prepared.Both now fall back to
"UTC", with fixture tests for a zone-less calendar list entry and a zone-less event review.Verification
pnpm exec tsx --test tests/google.test.ts— 27 pass, 0 fail (2 new)pnpm lintpnpm typecheckIntegration limits
Fixtures only; no live Google account was exercised.
AI assistance was used to prepare this change; I reviewed the code, tests and checks above.