fix: clear the mail draft error and ignore stale loads - #99
Open
nvtoan0201-swe wants to merge 1 commit into
Open
nvtoan0201-swe wants to merge 1 commit into
nvtoan0201-swe wants to merge 1 commit into
Conversation
The MailScreen drafts effect never cleared its error, so a banner from a past failure stayed after a later load succeeded. It also had no active guard, so a slow response could overwrite newer drafts. Clear the error before loading and ignore responses from an unmounted or superseded effect, matching the other data loaders in the file.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The
MailScreendrafts loader had two issues:errorstate was never cleared. A banner from a failed load stayed on screen after the server recovered and a later load succeeded./api/draftsresponse could overwrite newer drafts (last-resolved wins).The effect now clears the error before loading, ignores responses after unmount/supersession, and matches the pattern already used by
CalendarScreenand the other loaders inapps/mobile/src/screens.tsx.Verification
pnpm test— 276 pass, 0 failpnpm lintpnpm typecheck(root + mobile)No simulator/device run; the change is limited to the effect lifecycle in one screen.
Integration limits
Component lifecycle behavior is not covered by the repo's
node:testhelpers (they cover pure modules); this mirrors the existing screen loaders.AI assistance was used to prepare this change; I reviewed the code and ran the checks above.