Support live OpenGUI installation in WorkBuddy - #102
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6415da2fd2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| [ -n "$candidate" ] || continue | ||
| case "$executable" in "$candidate"/Contents/*) fail HOST_RUNNING 'Quit WorkBuddy with Command-Q after finishing phone tasks, then rerun this installer. No configuration was changed.' ;; esac | ||
| done | ||
| case "$executable" in "$app"/Contents/*) return 0 ;; esac |
There was a problem hiding this comment.
当机器上存在多个已识别的 WorkBuddy bundle 时,安装器会要求用 --app 选择一个,但这里仅检查所选 bundle 的进程。若另一个正在运行的旧版或副本使用相同的 dataFolderName(例如两个安装都使用 ~/.workbuddy),选择一个未运行的 5.5.6 bundle 就会让预检通过,并在仍由旧宿主使用的配置目录中写入文件,绕过本应触发的 HOST_RESTART_REQUIRED。请像此前逻辑一样检查所有候选 bundle,至少检查所有可能拥有该 config_root 的运行进程,再决定是否允许热安装。
Useful? React with 👍 / 👎.
WorkBuddy 5.5.6 can watch MCP configuration changes while running and can review external Hook changes from
/hooks, but the OpenGUI installer rejected every running WorkBuddy process. This made first installation require Command-Q and a separate Terminal command even when the host supported live configuration.This change allows WorkBuddy 5.5.6+ to remain open, keeps the restart fallback for older compatible hosts, updates the GitHub installation Skill to complete the install in the current task, and guides the user through
/hooksand/skills. It retains atomic configuration writes, old-broker upgrade blocking, immutable package directories, receipts, and rollback behavior. The public-testing version is bumped to 0.3.1.Validation:
LIVE_PREFLIGHT_OKwithout changing configurationquick_validate.py