fix(data): stop forcing every new table to kind 'data'#216
Merged
DavidBabinec merged 1 commit intoJul 12, 2026
Merged
Conversation
createTable in useDataWorkspace hard-coded kind: 'data' on every createCmsDataTable call, silently discarding the Kind selection made in NewTableDialog. Choosing "Post type" in the dialog always produced a plain data table with no title/slug/body/routing. Pass the dialog's input straight through instead of overriding it.
hrq-chiuchi
marked this pull request as ready for review
July 12, 2026 01:33
lauer3912
pushed a commit
to ClawCopilot/Instatic
that referenced
this pull request
Jul 20, 2026
lauer3912
pushed a commit
to ClawCopilot/Instatic
that referenced
this pull request
Jul 20, 2026
Cherry-picked 15 upstream commits across 5 phases: Phase 1 — Security: - ae7ed0d: CSP base-uri + object-src (CoreBunch#158) - c0087ec: XSS scheme-check htmlAttributes (CoreBunch#155) Phase 2 — Windows compatibility: - 75086cf: Windows port probing (CoreBunch#170) - fdfcb15: vite through entrypoint (CoreBunch#202) - 8c957fe: Windows-safe slot symlink swap (CoreBunch#187) Phase 3 — Editor fixes (7 commits): - Font weights, malformed fonts tolerance, empty container, canvas pan, layer icons, explorer tabs, responsive nav Phase 4 — CMS core: - 43abba0: Transactional site-document save (43 files) - 61fcebc: Stop forcing table kind 'data' (CoreBunch#216) - 3a4a6fc: Custom data-table fields editing (CoreBunch#182) Phase 5 — Other: - f139d3c: YouTube iframe routing (CoreBunch#151) - 6447a65: JSON-import media validation (CoreBunch#154) - 9a3af2d: Publisher media background optimization - 081e0d3: Collapse data.rows SQL query (CoreBunch#159) Additional workspace fixes: - Migration 020 conflict resolved (renumbered to 021) - staticArtefact.ts: Windows plain-file slot swap - 15 test files: EBUSY-safe cleanup on Windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createTableinsrc/admin/pages/data/hooks/useDataWorkspace.tsunconditionally spread{ ...input, kind: 'data' }intocreateCmsDataTable, overriding whateverkindthe New Table dialog actually sent.datatable instead — no title/slug/body fields, no routing, and (perTableSettings.tsx) table kind can't be changed after creation, so the only fix is deleting and recreating the table.kindcolumn.Fix
Pass
inputstraight through instead of overridingkind. The server (server/handlers/cms/data/tables.ts) already validatesbody.kindcorrectly, so no other changes needed.Test plan
bunx tsc -b --noEmitpassesbun testpasses (no existing coverage for this path — none broken)kind: 'postType', getstitle/slug/body/featuredMedia/seoTitle/seoDescriptionfields, and an auto-set/<slug>route base