Skip to content

fix: restore Storybook styles, dark mode and brand fonts - #17

Merged
jaavid merged 8 commits into
mainfrom
fix/storybook-themes-and-fonts
Sep 2, 2026
Merged

fix: restore Storybook styles, dark mode and brand fonts#17
jaavid merged 8 commits into
mainfrom
fix/storybook-themes-and-fonts

Conversation

@jaavid

@jaavid jaavid commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Closes #16

Root cause

Storybook loaded legacy global.css instead of the package stylesheet. Semantic tokens and component rules were therefore absent. The dark story only painted a dark wrapper, while text retained browser defaults. Font faces depended on local OS installations.

Fix

  • load stable and experimental package styles in the preview
  • configure light/dark themes through data-theme
  • remove the preview-wide forced RTL wrapper
  • define locale-aware typography tokens
  • self-host Noto Sans, Noto Sans Arabic and Handjet through Fontsource
  • align the Storybook canvas background and foreground with semantic tokens

Verification

CI, Storybook, deployed Cloudflare preview, computed fonts/colors, Persian RTL and English LTR will be checked before merge.


View with [code]smith
Need help on this PR? Tag @codesmith with what you need. Autofix is enabled.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 2, 2026

Copy link
Copy Markdown

Deploying design-system with  Cloudflare Pages  Cloudflare Pages

Latest commit: 82ec21e
Status: ✅  Deploy successful!
Preview URL: https://80e6c50c.design-system-dby.pages.dev
Branch Preview URL: https://fix-storybook-themes-and-fon.design-system-dby.pages.dev

View logs

@jaavid
jaavid merged commit abb1bd2 into main Sep 2, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: load production styles, themes and self-hosted fonts in Storybook

1 participant