fix: restore Storybook styles, dark mode and brand fonts - #17
Merged
Conversation
Deploying design-system with
|
| Latest commit: |
82ec21e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://80e6c50c.design-system-dby.pages.dev |
| Branch Preview URL: | https://fix-storybook-themes-and-fon.design-system-dby.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16
Root cause
Storybook loaded legacy
global.cssinstead of the package stylesheet. Semantic tokens and component rules were therefore absent. The dark story only painted a dark wrapper, while text retained browser defaults. Font faces depended on local OS installations.Fix
data-themeVerification
CI, Storybook, deployed Cloudflare preview, computed fonts/colors, Persian RTL and English LTR will be checked before merge.
Need help on this PR? Tag
@codesmithwith what you need. Autofix is enabled.