feat(ui): add OSC 8 hyperlink support for model URLs #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added hyperlink and hyperlink_url helper functions in ui::console - Updated �grep models info command to use clickable hyperlinks for model downloads - Improves UX in modern terminals supporting OSC 8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements OSC 8 hyperlink support for the \�grep models info\ command, addressing Issue #63.
Changes
Why
Currently, model URLs are displayed as plain text, requiring users to manually copy and paste them. Modern terminals support clickable hyperlinks, which significantly improves the user experience.
Verification
I have verified the implementation logic with a test case ensuring the correct OSC 8 escape sequences are generated.
\
ust
\x1b]8;;https://example.com\x07https://example.com\x1b]8;;\x07
\\