fix: escape SQL LIKE special characters to prevent query manipulation #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
search_similarfunction indb.rswas vulnerable to SQL LIKE pattern manipulation because user-provided path input was directly concatenated into the LIKE pattern without escaping special characters.Problem
When constructing the LIKE pattern, the code used:
This allowed attackers to inject SQL LIKE wildcards (
%,_) in the path parameter, potentially matching unintended paths and accessing data from paths they should not see.Solution
Escape SQL LIKE special characters before constructing the pattern:
This ensures that user-supplied wildcards are treated as literal characters rather than SQL pattern metacharacters.
Testing
The fix properly escapes:
%->\%(no longer acts as zero-or-more wildcard)_->\_(no longer acts as single-character wildcard)\->\\(proper escape sequence handling)Fixes PlatformNetwork/bounty-challenge#62