Fix: Surface non-2xx HTTP responses in client #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The TCP-based HTTP client now parses the HTTP status line and returns a clear error for non-2xx responses instead of attempting to deserialize error bodies as successful JSON payloads.
Problem
Client::searchandClient::embed_batchignored the HTTP status line and always tried to deserialize the response body into the success shape. When the server returned 4xx/5xx responses, this produced confusing errors like "Failed to parse server response".Solution
errorfield.searchandembed_batchnon-2xx responses.Testing
Related Issue
Fixes PlatformNetwork/bounty-challenge#73