fix: add timeouts to TCP client operations #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds connection, read, and write timeouts to the vgrep client to prevent indefinite hanging when the server is unresponsive or network is congested. Fixes PlatformNetwork/bounty-challenge#98
This was referenced Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses an issue where the TCP client in
vgrepwould hang indefinitely if the server was unresponsive or the network was congested. It introduces connection, read, and write timeouts to ensure the client fails gracefully instead of blocking forever.Changes
CONNECT_TIMEOUT(5s),READ_TIMEOUT(60s), andWRITE_TIMEOUT(60s) constants.Client::search,Client::embed_batch, andClient::healthto useTcpStream::connect_timeout.Validation
nc -l).Fixes PlatformNetwork/bounty-challenge#98