Skip to content

fix: handle TOCTOU race condition in file watcher #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
echobt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle TOCTOU race condition in file watcher #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/watcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,20 @@ impl FileWatcher {
// File was created or modified
let content = match std::fs::read_to_string(path) {
Ok(c) => c,
Err(e) if e.kind() == std::io::ErrorKind::NotFound => {
// File was deleted between check and read (TOCTOU)
if let Some(entry) = db.get_file_by_path(path)? {
db.delete_file(entry.id)?;
println!(
" {} {} {} {}",
style("[-]").red(),
style("removed").red(),
style(filename).dim(),
style("(race condition handled)").dim()
);
}
continue;
}
Err(_) => continue, // Skip binary or unreadable files
};

Expand Down
Loading