fix: correct chunk overlap calculation to use configured overlap #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where chunk overlap was calculated using an arbitrary magic number (40) division, which resulted in minimal and inconsistent overlap regardless of the configuration.
Changes
chunk_overlap / 40logic with a character-based overlap calculation.chunk_overlapcharacter count (or slightly exceeds it to include complete lines).src/core/indexer.rsandsrc/watcher.rs.Verification