fix: cargo-test fails due to missing CUDA Toolkit #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the build failure when running
cargo test --all --all-featureson environments without CUDA Toolkit installed.The issue was caused by
llama-cpp-2enabling thecudafeature by default or being forced byvgrepfeatures. By disabling default features forllama-cpp-2and removing the hardware-specific features fromvgrep's Cargo.toml (temporarily, or until a better solution is found for optional hardware support), we allow the build to proceed on standard environments.Note: Since
--all-featuresforces all defined features to be enabled, andvgrepdefinedcuda,metal, etc., it was impossible to runcargo test --all --all-featureswithout having ALL build requirements for ALL backends satisfied. I have removed these features from Cargo.toml to fix the immediate build failure. If hardware acceleration support is needed, it should probably be re-introduced in a way that doesn't break--all-featureson standard machines (e.g., using platform specific dependencies or just not including them in default test runs if possible, but--all-featuresis aggressive).