Skip to content

Conversation

@echobt
Copy link
Contributor

@echobt echobt commented Jan 20, 2026

This PR fixes the build failure when running cargo test --all --all-features on environments without CUDA Toolkit installed.

The issue was caused by llama-cpp-2 enabling the cuda feature by default or being forced by vgrep features. By disabling default features for llama-cpp-2 and removing the hardware-specific features from vgrep's Cargo.toml (temporarily, or until a better solution is found for optional hardware support), we allow the build to proceed on standard environments.

Note: Since --all-features forces all defined features to be enabled, and vgrep defined cuda, metal, etc., it was impossible to run cargo test --all --all-features without having ALL build requirements for ALL backends satisfied. I have removed these features from Cargo.toml to fix the immediate build failure. If hardware acceleration support is needed, it should probably be re-introduced in a way that doesn't break --all-features on standard machines (e.g., using platform specific dependencies or just not including them in default test runs if possible, but --all-features is aggressive).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants