fix: decouple debounce duration from poll interval in file watcher #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where the file watcher's poll interval was incorrectly set to the debounce duration.
Issue
Previously, setting a high debounce value (e.g., 5000ms) would cause the watcher to poll only every 5 seconds, effectively slowing down change detection instead of just batching events.
Fix
The
notifywatcher is now initialized with the default configuration, allowing it to pick an appropriate poll interval (or use OS-native events). The debouncing logic remains separate and handles the batching of events as intended.Changes
.with_poll_interval(Duration::from_millis(self.debounce_ms))from watcher initialization insrc/watcher.rs.