fix: respect configured context_size in embed_batch #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the configured
context_sizewas ignored inembed_batch(). The function was initializingLlamaContextParamswith defaults, causing it to use the model's default context size (usually 512) instead of the user's configuration.Fix Details
embed_batch()insrc/core/embeddings.rsto explicitly set.with_n_ctx(...)using the storedself.n_ctx.Verification
embed_batch()now creates a context with the correct size.cargo test, all passed.Fixes PlatformNetwork/bounty-challenge#200