fix: prevent max_file_size from being set to 0 #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where setting
max_file_sizeto 0 in the configuration was silently accepted, causing all files to be skipped during indexing.Changes
commands.rsto reject 0 as a value formax-file-size.Max file size must be greater than 0.Verification
Reproduced the issue by running:
vgrep config set max-file-size 0Before the fix, this succeeded. After the fix, it returns an error and prevents the invalid configuration.
Related to bounty issue #204.