Skip to content

Conversation

@echobt
Copy link
Contributor

@echobt echobt commented Jan 21, 2026

Description

This PR fixes an issue where the download progress bar would remain visible if the model download failed, corrupting the terminal output.

Changes

  • Modified run_models in src/cli/commands.rs to separate the download call from the result handling.
  • Ensures pb.finish_and_clear() is called before propagating any errors from the download operation.

Verification

  • Verified by code analysis and local reproduction simulation (not included in PR) where early return prevented cleanup.
  • Ran existing tests: cargo test passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants