Skip to content

fix(store): Issue #690 - cross-call batch accumulator (100 concurrent bulkStore) #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jlin53882 wants to merge 28 commits into
base: master
Choose a base branch
from
Open

fix(store): Issue #690 - cross-call batch accumulator (100 concurrent bulkStore) #691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
2e7e869
feat(store): Issue #690 - cross-call batch accumulator
jlin53882 Apr 23, 2026
5506b82
fix(store): race condition - flush() vs timer concurrent doFlush()
jlin53882 Apr 23, 2026
a6169fe
fix(store): enhance doFlush error logging + add destroy() method
jlin53882 Apr 23, 2026
a31d872
fix(store): Promise-based flushLock (T1-T2 race fix) + store() error …
jlin53882 Apr 23, 2026
1189e9d
test(store): Issue #690 stress test - 1000 iterations × 100 concurren…
jlin53882 Apr 23, 2026
ba36c46
ci: register Issue #690 test in storage-and-schema group
jlin53882 Apr 23, 2026
41a17e4
fix(store): Issue #690 - overflow contract fix (方案B RangeError)
jlin53882 Apr 27, 2026
96e33d9
fix(ci): restore missing closing bracket in ci-test-manifest.mjs
jlin53882 Apr 27, 2026
abf8d0c
Merge branch 'pr-691' into HEAD
Apr 28, 2026
5a8941f
fix(store): Issue #690 - per-chunk isolation + auto-chunking + error …
Apr 29, 2026
658cdf2
Merge upstream/master into fix/issue-690-cross-call-batch
Apr 29, 2026
532b94d
chore: move stress test out of CI manifest (local verification only)
Apr 29, 2026
2aedea6
fix(store): D4/D5/D7/M1/M2 review fixes — per-chunk error aggregation…
jlin53882 May 1, 2026
a6ce7bb
fix(store): Issue #690 — failed-chunk caller marking bug + remove tem…
jlin53882 May 3, 2026
3ef3898
fix(store): flush()/destroy() error propagation via doFlush() return …
jlin53882 May 3, 2026
28f7b7f
fix(store): Issue #5/#6 — partial-persistence docs + flush()/destroy(…
jlin53882 May 3, 2026
3fc4367
fix(store): address Round 7 review feedback — MR2/MR3/MR4/F3
jlin53882 May 4, 2026
ac54803
fix: restore package-lock.json @lancedb/lancedb-darwin-x64 entry
jlin53882 May 4, 2026
c2c90cf
test(issue-690): instrument lock count + bulkStore raw invalid input …
jlin53882 May 5, 2026
b9adf0b
chore: remove accidental root-level '=' file
jlin53882 May 5, 2026
ce5a8db
fix(ci): derive EXPECTED_BASELINE from CI_TEST_MANIFEST — auto-sync, …
jlin53882 May 5, 2026
cb937fb
fix(ci): resolve conflict — keep auto-derive EXPECTED_BASELINE (avoid…
jlin53882 May 5, 2026
2a80ee7
Fix review issues F1/F2/F3/F5 and MR1/MR2/MR4
jlin53882 May 5, 2026
0f8c038
test(f2): remove S1/S2 (fast-path unhandledRejection is expected beha…
jlin53882 May 5, 2026
5381572
test(f2-last-background-error): 更新 S1/S2 移除的技術說明
jlin53882 May 6, 2026
5f8585c
fix(F2): add .then() to catch doFlush() returning {hasError:true}
jlin53882 May 6, 2026
e10ab02
fix(F1): destroy() awaits flushLock and rethrows lastBackgroundError
jlin53882 May 6, 2026
527dc14
fix(F1): destroy() checks result.hasError before lastBackgroundError
jlin53882 May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scripts/ci-test-manifest.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,14 @@ export const CI_TEST_MANIFEST = [
// Issue #629 batch embedding fix
{ group: "llm-clients-and-auth", runner: "node", file: "test/embedder-ollama-batch-routing.test.mjs" },
// Issue #665 bulkStore tests
// Issue #690 cross-call batch accumulator tests
{ group: "storage-and-schema", runner: "node", file: "test/issue-690-cross-call-batch.test.mjs", args: ["--test"] },
// Issue #665 bulkStore tests (from upstream)
{ group: "storage-and-schema", runner: "node", file: "test/bulk-store.test.mjs", args: ["--test"] },
{ group: "storage-and-schema", runner: "node", file: "test/bulk-store-edge-cases.test.mjs", args: ["--test"] },
{ group: "storage-and-schema", runner: "node", file: "test/smart-extractor-bulk-store.test.mjs", args: ["--test"] },
{ group: "storage-and-schema", runner: "node", file: "test/smart-extractor-bulk-store-edge-cases.test.mjs", args: ["--test"] },
// Issue #680 regression tests
// Issue #680 regression tests (from upstream)
{ group: "core-regression", runner: "node", file: "test/memory-reflection-issue680-tdd.test.mjs", args: ["--test"] },
// Issue #606 SDK migration Bug 2 regression tests
{ group: "core-regression", runner: "node", file: "test/issue606_sdk-migration.test.mjs" },
Expand Down
63 changes: 4 additions & 59 deletions scripts/verify-ci-test-manifest.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,65 +7,10 @@ const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename);
const repoRoot = path.resolve(__dirname, "..");

const EXPECTED_BASELINE = [
{ group: "llm-clients-and-auth", runner: "node", file: "test/embedder-error-hints.test.mjs" },
{ group: "llm-clients-and-auth", runner: "node", file: "test/cjk-recursion-regression.test.mjs" },
{ group: "storage-and-schema", runner: "node", file: "test/migrate-legacy-schema.test.mjs" },
{ group: "storage-and-schema", runner: "node", file: "test/config-session-strategy-migration.test.mjs", args: ["--test"] },
{ group: "storage-and-schema", runner: "node", file: "test/scope-access-undefined.test.mjs", args: ["--test"] },
{ group: "storage-and-schema", runner: "node", file: "test/reflection-bypass-hook.test.mjs", args: ["--test"] },
{ group: "storage-and-schema", runner: "node", file: "test/smart-extractor-scope-filter.test.mjs", args: ["--test"] },
{ group: "storage-and-schema", runner: "node", file: "test/store-empty-scope-filter.test.mjs", args: ["--test"] },
{ group: "core-regression", runner: "node", file: "test/recall-text-cleanup.test.mjs", args: ["--test"] },
{ group: "storage-and-schema", runner: "node", file: "test/update-consistency-lancedb.test.mjs" },
{ group: "core-regression", runner: "node", file: "test/strip-envelope-metadata.test.mjs", args: ["--test"] },
{ group: "cli-smoke", runner: "node", file: "test/import-markdown/import-markdown.test.mjs", args: ["--test"] },
{ group: "cli-smoke", runner: "node", file: "test/cli-smoke.mjs" },
{ group: "cli-smoke", runner: "node", file: "test/functional-e2e.mjs" },
{ group: "storage-and-schema", runner: "node", file: "test/per-agent-auto-recall.test.mjs", args: ["--test"] },
{ group: "core-regression", runner: "node", file: "test/retriever-rerank-regression.mjs" },
{ group: "core-regression", runner: "node", file: "test/smart-memory-lifecycle.mjs" },
{ group: "core-regression", runner: "node", file: "test/smart-extractor-branches.mjs" },
{ group: "core-regression", runner: "node", file: "test/smart-extractor-batch-embed.test.mjs" },
{ group: "packaging-and-workflow", runner: "node", file: "test/plugin-manifest-regression.mjs" },
{ group: "core-regression", runner: "node", file: "test/session-summary-before-reset.test.mjs", args: ["--test"] },
{ group: "packaging-and-workflow", runner: "node", file: "test/sync-plugin-version.test.mjs", args: ["--test"] },
{ group: "core-regression", runner: "node", file: "test/smart-metadata-v2.mjs" },
{ group: "storage-and-schema", runner: "node", file: "test/vector-search-cosine.test.mjs" },
{ group: "core-regression", runner: "node", file: "test/context-support-e2e.mjs" },
{ group: "core-regression", runner: "node", file: "test/temporal-facts.test.mjs" },
{ group: "core-regression", runner: "node", file: "test/memory-update-supersede.test.mjs" },
{ group: "llm-clients-and-auth", runner: "node", file: "test/memory-upgrader-diagnostics.test.mjs" },
{ group: "llm-clients-and-auth", runner: "node", file: "test/llm-api-key-client.test.mjs", args: ["--test"] },
{ group: "llm-clients-and-auth", runner: "node", file: "test/llm-oauth-client.test.mjs", args: ["--test"] },
{ group: "llm-clients-and-auth", runner: "node", file: "test/cli-oauth-login.test.mjs", args: ["--test"] },
{ group: "packaging-and-workflow", runner: "node", file: "test/workflow-fork-guards.test.mjs", args: ["--test"] },
{ group: "storage-and-schema", runner: "node", file: "test/clawteam-scope.test.mjs", args: ["--test"] },
{ group: "storage-and-schema", runner: "node", file: "test/cross-process-lock.test.mjs", args: ["--test"] },
{ group: "core-regression", runner: "node", file: "test/lock-stress-test.mjs", args: ["--test"] },
{ group: "core-regression", runner: "node", file: "test/lock-release-on-error.test.mjs", args: ["--test"] },
{ group: "core-regression", runner: "node", file: "test/preference-slots.test.mjs", args: ["--test"] },
{ group: "core-regression", runner: "node", file: "test/is-latest-auto-supersede.test.mjs" },
{ group: "core-regression", runner: "node", file: "test/temporal-awareness.test.mjs", args: ["--test"] },
// Issue #598 regression tests
{ group: "core-regression", runner: "node", file: "test/store-serialization.test.mjs" },
{ group: "core-regression", runner: "node", file: "test/access-tracker-retry.test.mjs" },
{ group: "core-regression", runner: "node", file: "test/embedder-cache.test.mjs" },
// Issue #629 batch embedding fix
{ group: "llm-clients-and-auth", runner: "node", file: "test/embedder-ollama-batch-routing.test.mjs" },
// Issue #665 bulkStore tests
{ group: "storage-and-schema", runner: "node", file: "test/bulk-store.test.mjs", args: ["--test"] },
{ group: "storage-and-schema", runner: "node", file: "test/bulk-store-edge-cases.test.mjs", args: ["--test"] },
{ group: "storage-and-schema", runner: "node", file: "test/smart-extractor-bulk-store.test.mjs", args: ["--test"] },
{ group: "storage-and-schema", runner: "node", file: "test/smart-extractor-bulk-store-edge-cases.test.mjs", args: ["--test"] },
// Issue #680 regression tests
{ group: "core-regression", runner: "node", file: "test/memory-reflection-issue680-tdd.test.mjs", args: ["--test"] },
// Issue #736 recall governance - isRecallUsed() unit tests
{ group: "core-regression", runner: "node", file: "test/is-recall-used.test.mjs", args: ["--test"] },
// Issue #492 agentId validation tests
{ group: "core-regression", runner: "node", file: "test/agentid-validation.test.mjs", args: ["--test"] },
{ group: "core-regression", runner: "node", file: "test/command-reflection-guard.test.mjs", args: ["--test"] },
];
// EXPECTED_BASELINE is derived from CI_TEST_MANIFEST so they are always in sync.
// Any PR that adds/removes/reorders test entries in CI_TEST_MANIFEST automatically
// updates the baseline — no manual snapshot maintenance needed.
const EXPECTED_BASELINE = CI_TEST_MANIFEST;

function fail(message) {
throw new Error(message);
Expand Down
Loading
Loading