feat(import-markdown): --no-dedup by default, new return fields, unified summary (closes #715)#719
Closed
jlin53882 wants to merge 1 commit intoCortexReach:masterfrom
Closed
Conversation
…ied summary - --dedup flag inverted: now --no-dedup disables dedup (default true) - Return type expanded: added skippedShort, skippedDedup, errorCount - Early return with no files now returns all 6 fields (TypeError fix) - Summary unified: single 'Memory Import Status:' format replaces dual dry-run/real modes - Log tags: [scan], [would-import], [skip] for consistent output - dedup skip log always shown (removed if(!dryRun) guard) - errorCount tracked separately; error log uses [skip] error: prefix - TotalEntries computed and reported in summary Based on PR CortexReach#717 intent (Issue CortexReach#715), rebuilt cleanly from upstream/master
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Apr 29, 2026
Contributor
Author
Contributor
Author
|
Closed — superseded by #733 (clean rebuild) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rebuilt cleanly from upstream/master based on PR #717 intent (Issue #715), containing only the relevant changes:
--dedupto--no-dedup(Commander.js invert pattern)skippedShort,skippedDedup,errorCountfieldsMemory Import Status:format replaces dual dry-run/real modes[scan],[would-import],[skip] dedup,[skip] errorif (!dryRun)guard[skip] error:prefixChanges (cli.ts only, +31 / -18 lines)
--dedup--no-dedup{ imported, skipped, foundFiles }{ imported, skipped, foundFiles, skippedShort, skippedDedup, errorCount }[dry-run] would import:[would-import] [scope][skip] already imported:(dry-run hidden)[skip] dedup [scope]:(always shown)Memory Import Status:skippedincludes short+read-err onlyskipped= short+dedup+read-err+error; granular counts in new fieldsTest Results
All 14 existing tests pass (import-markdown.test.mjs — no test changes needed, new fields are backward-compatible with existing assertions).
Related Issues