fix: prevent memory leak by pruning lifecycleEntries and tierOverrides maps#726
Open
zhangshu9206 wants to merge 1 commit intoCortexReach:masterfrom
Open
Conversation
…s maps - Add LIFECYCLE_ENTRIES_MAX_SIZE (500) and TIER_OVERRIDES_MAX_SIZE (200) constants. - Call pruneMapIfOver() after populating lifecycleEntries and tierOverrides to prevent unbounded memory growth. - Add DEFAULT_REFLECTION_AGENT_CACHE_MAX_SIZE (50) constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a memory leak in the Gateway caused by unbounded growth of
lifecycleEntriesandtierOverridesMap objects inindex.ts.Problem
The
lifecycleEntriesandtierOverridesMaps were being populated on every lifecycle event and tier transition but never cleaned up, leading to continuous memory growth (approx. 150 MB/hour).Fix
LIFECYCLE_ENTRIES_MAX_SIZE(500) andTIER_OVERRIDES_MAX_SIZE(200) constants.pruneMapIfOver()after populating both Maps to prevent unbounded growth.DEFAULT_REFLECTION_AGENT_CACHE_MAX_SIZE(50) constant for consistency.Impact
Verification